Add async test cases for project deletion.#703
Merged
simondeziel merged 1 commit intocanonical:mainfrom Feb 24, 2026
Merged
Conversation
… project deletion Signed-off-by: tugbataluy <tugba.taluy@canonical.com>
tugbataluy
force-pushed
the
add_async_project_deletion_test
branch
from
81165b5 to
c41a171
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds unit tests for asynchronous project deletion following the LXD API change that made project deletion asynchronous. The tests verify that pylxd's existing base class properly handles both wait=True and wait=False cases for Project.delete().
Changes:
- Added
TestProjectAsynctest class with async operation tests for project deletion - Added tests for
delete(wait=True)anddelete(wait=False)scenarios - Added mock helpers to simulate async delete responses
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simondeziel
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the recent LXD API change (lxd#17648) that made project deletion asynchronous, this PR adds unit tests to explicitly verify that pylxd handles both the
wait=Trueandwait=Falsecases correctly forProject.delete().No functional changes were required, the existing base class already handles async responses transparently. These tests document and protect that behaviour going forward.